add extensions to otel.trace #77
Open
+128
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
reviewed
Oct 24, 2024
Comment on lines
+883
to
+907
| val to_span_link : | ||
| ?trace_state:string -> | ||
| ?attrs:key_value list -> | ||
| ?dropped_attributes_count:int -> | ||
| t -> | ||
| Span_link.t | ||
| (** Turn the scope into a span link *) |
There was a problem hiding this comment.
I'm currently doing the following in a codebase to get the span_link
scope |> Scope.to_span_ctx |> Span_link.of_span_ctxIs the Span_link.of_span_ctx still required now that we can go directly from scope to span_link ?
There was a problem hiding this comment.
And if yes, should we add ?dropped_attributes_count:int to the Span_link.of_span_ctx to be consistent ?
There was a problem hiding this comment.
I think we can keep both, but yes, adding the optional arguments is good for consistency.
c-cube
force-pushed
the
simon/trace-add-span-link
branch
from
a83464b to
e789462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span_kind.t, add {kind,set_kind} toScope